修复非浙政钉用户编辑报错

pmapi/src/main/java/com/ningdatech/pmapi/user/manage/UserInfoManage.java

@@ -12,6 +12,7 @@ import com.ningdatech.pmapi.common.constant.RegionConst;
 import com.ningdatech.pmapi.common.helper.RegionCacheHelper;
 import com.ningdatech.pmapi.common.helper.UserInfoHelper;
 import com.ningdatech.pmapi.common.util.BizUtils;
+import com.ningdatech.pmapi.common.util.StrUtils;
 import com.ningdatech.pmapi.ding.constants.DingOrganizationContant;
 import com.ningdatech.pmapi.organization.model.entity.DingEmployeeInfo;
 import com.ningdatech.pmapi.organization.model.entity.DingOrganization;
@@ -37,6 +38,7 @@ import com.ningdatech.zwdd.ZwddIntegrationProperties;
 import com.ningdatech.zwdd.client.ZwddClient;
 import com.wflow.workflow.bean.dto.ProcessInstanceUserDto;
 import lombok.RequiredArgsConstructor;
+import org.springframework.aop.framework.AopContext;
 import org.springframework.stereotype.Component;
 import org.springframework.transaction.annotation.Transactional;
 
@@ -85,7 +87,7 @@ public class UserInfoManage {
                 .like(StringUtils.isNotBlank(phoneNo), UserInfo::getMobile, phoneNo)
                 .like(StringUtils.isNotBlank(name), UserInfo::getRealName, name)
                 .in(Objects.nonNull(userIdList), UserInfo::getId, userIdList)
-                .eq(Objects.nonNull(regionId), UserInfo::getRegionCode,regionId)
+                .eq(Objects.nonNull(regionId), UserInfo::getRegionCode, regionId)
                 .like(StringUtils.isNotBlank(orgName), UserInfo::getEmpPosUnitName, orgName)
                 .eq(StringUtils.isNotBlank(orgCode), UserInfo::getEmpPosUnitCode, orgCode)
                 .orderByDesc(UserInfo::getUpdateOn);
@@ -188,7 +190,7 @@ public class UserInfoManage {
      * @param userRoleList
      */
     private List<Long> getRoleCompliantUserIdList(List<UserRoleVO> userRoleList) {
-        if(CollUtil.isNotEmpty(userRoleList)){
+        if (CollUtil.isNotEmpty(userRoleList)) {
             userRoleList = userRoleList.stream().filter(r -> Objects.nonNull(r.getId())).collect(Collectors.toList());
         }
         if (CollUtil.isEmpty(userRoleList)) {
@@ -250,12 +252,21 @@ public class UserInfoManage {
         return userRoleInfoList;
     }
 
-    public void disableOrEnable(ReqUserDisableOrEnablePO reqUserDisableOrEnablePO) {
-        Long userId = generateUserId(reqUserDisableOrEnablePO.getEmployeeCode());
+    @Transactional(rollbackFor = Exception.class)
+    public void disableOrEnable(ReqUserDisableOrEnablePO req) {
+        Long userId;
+        if (req.getUserId() != null) {
+            userId = req.getUserId();
+        } else if (StrUtils.isNotBlank(req.getEmployeeCode())) {
+            UserInfoManage proxy = (UserInfoManage) AopContext.currentProxy();
+            userId = proxy.generateUserId(req.getEmployeeCode());
+        } else {
+            throw BizException.wrap("用户参数缺失");
+        }
         UserInfo userInfo = iUserInfoService.getById(userId);
-        userInfo.setAvailable(reqUserDisableOrEnablePO.getOperation());
+        userInfo.setAvailable(req.getOperation());
         iUserInfoService.updateById(userInfo);
-        if (userInfo.getAvailable().equals("DISABLE")) {
+        if ("DISABLE".equals(userInfo.getAvailable())) {
             userAuthManage.kickOff(userId);
         }
 
@@ -353,24 +364,24 @@ public class UserInfoManage {
         String mobile = userInfo.getMobile();
         Long userId = userInfo.getId();
 //        if (StringUtils.isBlank(mobile)) {
-            // 校验手机号是否重复
-            UserInfo repeatMobileUserInfo = iUserInfoService.getOne(Wrappers.lambdaQuery(UserInfo.class)
-                    .eq(UserInfo::getMobile, reqUserDetailEditPO.getPhoneNo()).ne(UserInfo::getId, userId));
-            if (Objects.nonNull(repeatMobileUserInfo)) {
-                throw new BizException("该手机号码已被绑定，请问重复绑定");
-            }
-
-            String phoneNo = reqUserDetailEditPO.getPhoneNo();
-            userInfo.setMobile(phoneNo);
-            // 更新浙政钉相关数据
-            if (StringUtils.isNotBlank(phoneNo)) {
-                iDingEmployeeInfoService
-                        .update(Wrappers.lambdaUpdate(DingEmployeeInfo.class)
-                                .eq(DingEmployeeInfo::getMainJob, "true")
-                                .eq(DingEmployeeInfo::getEmployeeCode, employeeCode)
-                                .set(DingEmployeeInfo::getBindUserMobile, phoneNo));
-                iUserInfoService.updateById(userInfo);
-            }
+        // 校验手机号是否重复
+        UserInfo repeatMobileUserInfo = iUserInfoService.getOne(Wrappers.lambdaQuery(UserInfo.class)
+                .eq(UserInfo::getMobile, reqUserDetailEditPO.getPhoneNo()).ne(UserInfo::getId, userId));
+        if (Objects.nonNull(repeatMobileUserInfo)) {
+            throw new BizException("该手机号码已被绑定，请问重复绑定");
+        }
+
+        String phoneNo = reqUserDetailEditPO.getPhoneNo();
+        userInfo.setMobile(phoneNo);
+        // 更新浙政钉相关数据
+        if (StringUtils.isNotBlank(phoneNo)) {
+            iDingEmployeeInfoService
+                    .update(Wrappers.lambdaUpdate(DingEmployeeInfo.class)
+                            .eq(DingEmployeeInfo::getMainJob, "true")
+                            .eq(DingEmployeeInfo::getEmployeeCode, employeeCode)
+                            .set(DingEmployeeInfo::getBindUserMobile, phoneNo));
+            iUserInfoService.updateById(userInfo);
+        }
 //        }
 
     }
@@ -450,13 +461,14 @@ public class UserInfoManage {
 
     //生成头像 链接
     private String makeAvatar(String avatar) {
-        try{
+        try {
             GenericResult<String> accessToken = zwddClient.getAccessToken();
             String token = accessToken.getData();
             String res = "https://" + zwddIntegrationProperties.getDomain() + "/media/download?" +
                     "access_token=" + token + "&media_id=" + avatar;
             return res;
-        }catch (Exception e){}
+        } catch (Exception e) {
+        }
         return org.apache.commons.lang3.StringUtils.EMPTY;
     }
 

pmapi/src/main/java/com/ningdatech/pmapi/user/model/po/ReqUserDisableOrEnablePO.java

@@ -18,7 +18,6 @@ public class ReqUserDisableOrEnablePO {
     @ApiModelProperty("用户id")
     private Long userId;
 
-    @NotBlank(message = "浙政钉 用户编码 不能为空")
     @ApiModelProperty("浙政钉 用户编码")
     private String employeeCode;
 

pmapi/src/main/java/com/ningdatech/pmapi/workbench/manage/WorkbenchManage.java

@@ -5,6 +5,7 @@ import com.ningdatech.pmapi.projectdeclared.manage.DeclaredProjectManage;
 import com.ningdatech.pmapi.projectdeclared.manage.DefaultDeclaredProjectManage;
 import com.ningdatech.pmapi.projectlib.manage.ProjectLibManage;
 import com.ningdatech.pmapi.projectlib.model.req.ProjectListReq;
+import com.ningdatech.pmapi.projectlib.model.vo.ProjectLibListItemVO;
 import com.ningdatech.pmapi.sys.manage.NoticeManage;
 import com.ningdatech.pmapi.sys.model.req.NoticeListReq;
 import com.ningdatech.pmapi.todocenter.manage.TodoCenterManage;
@@ -17,6 +18,8 @@ import com.ningdatech.pmapi.workbench.converter.WorkbenchConverter;
 import com.ningdatech.pmapi.workbench.model.vo.WorkbenchVO;
 import lombok.AllArgsConstructor;
 import org.springframework.stereotype.Component;
+
+import java.util.ArrayList;
 import java.util.concurrent.CompletableFuture;
 import java.util.concurrent.ForkJoinPool;
 import java.util.stream.Collectors;
@@ -56,7 +59,7 @@ public class WorkbenchManage {
                     toBeProcessedReq.setPageSize(5);
                     toBeProcessedReq.setEmployeeCode(user.getEmployeeCode());
                     statisticsVO.setTodoList(todoCenterManage.todoProjectList(toBeProcessedReq).getRecords()
-                            .stream().map(v -> WorkbenchConverter.convert(v)).collect(Collectors.toList()));
+                            .stream().map(WorkbenchConverter::convert).collect(Collectors.toList()));
                     res.setTodoCerter(statisticsVO);
                 }, ForkJoinPool.commonPool()),
                 CompletableFuture.runAsync(()-> {
@@ -81,8 +84,7 @@ public class WorkbenchManage {
         projectListReq.setPageSize(5);
         projectListReq.setProjectYear(year);
         projectListReq.setBuildOrgCode(user.getEmpPosUnitCode());
-        res.setProjects(projectLibManage.projectLibListWithPermission(projectListReq,user).getRecords().stream().collect(Collectors.toList()));
-
+        res.setProjects(new ArrayList<>(projectLibManage.projectLibListWithPermission(projectListReq, user).getRecords()));
         return res;
     }
 }